Skip to content

@extschema@. Legacy leads to leakage#59

Merged
ChuckHend merged 2 commits into
ChuckHend:mainfrom
vsTianhao:patch-1
Mar 12, 2026
Merged

@extschema@. Legacy leads to leakage#59
ChuckHend merged 2 commits into
ChuckHend:mainfrom
vsTianhao:patch-1

Conversation

@vsTianhao

Copy link
Copy Markdown
Contributor

No description provided.

@dino2gnt

dino2gnt commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

Can you provide additional detail on what exactly this fixes?

@vsTianhao

Copy link
Copy Markdown
Contributor Author

Can you provide additional detail on what exactly this fixes?

These aggregation functions leaked into the public schema

@ChuckHend

Copy link
Copy Markdown
Owner

Should we also put make_view_incremental in the extension schema?

@vsTianhao

Copy link
Copy Markdown
Contributor Author

Should we also put make_view_incremental in the extension schema?

I think it should also be in the extension schema instead of public, so everything created by the extension stays in the same namespace.

@ChuckHend

Copy link
Copy Markdown
Owner

I think it should also be in the extension schema instead of public, so everything created by the extension stays in the same namespace.

I agree. Can you add that to this PR?

@ChuckHend
ChuckHend merged commit 5127529 into ChuckHend:main Mar 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants