Conversation
There was a problem hiding this comment.
Pull request overview
This PR centralizes the duplicated “job cache + pg_notify listener” functionality by moving the shared implementation into vectorize-core, and updating server and proxy to call into that shared module.
Changes:
- Added
vectorize_core::cachemodule containing the shared job notification trigger setup, listener loop, and cache refresh/load logic. - Updated
serverandproxycache modules to delegate to (and re-export) the shared core implementations. - Added
tracingtovectorize-coredependencies to support the moved logging.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| server/src/cache.rs | Removes local cache-sync implementations and delegates to vectorize_core::cache. |
| proxy/src/cache.rs | Removes local cache-sync implementations and delegates to vectorize_core::cache. |
| core/src/lib.rs | Exposes the new cache module from the core crate. |
| core/src/cache.rs | New shared implementation for trigger setup, listener, refresh, and initial cache load. |
| core/Cargo.toml | Adds tracing dependency required by the new core cache module. |
| Cargo.lock | Lockfile update reflecting the new tracing dependency for vectorize-core. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.