Skip to content

dedupe fns#272

Merged
ChuckHend merged 2 commits into
mainfrom
dedupe
May 28, 2026
Merged

dedupe fns#272
ChuckHend merged 2 commits into
mainfrom
dedupe

Conversation

@ChuckHend

Copy link
Copy Markdown
Owner

No description provided.

@ChuckHend
ChuckHend marked this pull request as ready for review May 27, 2026 16:32
@ChuckHend
ChuckHend requested a review from Copilot May 27, 2026 16:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR centralizes the duplicated “job cache + pg_notify listener” functionality by moving the shared implementation into vectorize-core, and updating server and proxy to call into that shared module.

Changes:

  • Added vectorize_core::cache module containing the shared job notification trigger setup, listener loop, and cache refresh/load logic.
  • Updated server and proxy cache modules to delegate to (and re-export) the shared core implementations.
  • Added tracing to vectorize-core dependencies to support the moved logging.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
server/src/cache.rs Removes local cache-sync implementations and delegates to vectorize_core::cache.
proxy/src/cache.rs Removes local cache-sync implementations and delegates to vectorize_core::cache.
core/src/lib.rs Exposes the new cache module from the core crate.
core/src/cache.rs New shared implementation for trigger setup, listener, refresh, and initial cache load.
core/Cargo.toml Adds tracing dependency required by the new core cache module.
Cargo.lock Lockfile update reflecting the new tracing dependency for vectorize-core.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread server/src/cache.rs Outdated
Comment thread proxy/src/cache.rs Outdated
@ChuckHend
ChuckHend merged commit 1a3b504 into main May 28, 2026
8 checks passed
@ChuckHend
ChuckHend deleted the dedupe branch May 28, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants