feat: Trade Matching & Suggestions module - #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27
Body
Summary
Adds a lightweight trade matching system that ranks compatible listings for a given listing and lets users propose trades directly from the marketplace.
What's included
Matching algorithm (
src/services/matchService.ts)UI components
SuggestedMatches— displays ranked match cards with score breakdown bars, human-readable reasons, and a "Propose trade" action with optional messageListingCard— new "Find matches" button per listingListingCreate— new tags input (Enter to add, clickable chips)MarketplaceClient— "matches" view with back-navigationTypes & data (
src/types/listing.ts)tags: string[]toListingMatchSuggestion,TradeMatchResult,TradeProposal,TradeProposalStatusProposal management (localStorage-backed)
proposeTrade,acceptProposal,declineProposal,getProposalsForListingAnalytics
listing_view(when viewing matches) andmatch_proposeevents via existinguseAnalyticshookTests (
src/services/__tests__/matchService.unit.test.ts)scoreCategory,scoreTags,scoreValue, andfindMatches— including exclusion logic, ranking, breakdown integrity, and edge casesFiles changed (9 files, +954 / -13)
src/types/listing.tstagsonListing, new match/proposal typessrc/services/matchService.tssrc/services/listingService.tssrc/components/SuggestedMatches.tsxsrc/components/MarketplaceClient.tsxsrc/components/ListingCard.tsxsrc/components/ListingList.tsxonFindMatchespropsrc/components/ListingCreate.tsxsrc/services/__tests__/matchService.unit.test.tsVerification
next build— compiled successfullytsc --noEmit— zero type errorsnext lint— no warnings or errorsjest— 125/125 tests pass (13 suites)