Add OSAL abstraction for closing sockets#48
Open
mzella-ll wants to merge 1 commit into
Open
Conversation
- Add OSAL wrapper for closing sockets - Use OSAL socket close wrapper in CoAP
mzella-ll
force-pushed
the
feature/add-osal-socket-close
branch
from
893429b to
e0e0d0e
Compare
manojnacsl
approved these changes
Jun 10, 2026
Collaborator
There was a problem hiding this comment.
Changes look good - approved.
- Please check build/sanity for all the impacted platforms to ensure no build breakage.
- Close #47 after merging this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends the OSAL socket interface with a wrapper for closing sockets.
The OSAL already provides
osal_socket()for opening sockets. This PR adds the correspondingosal_socket_close()function and uses it in the CoAP client/server code instead of callingclose()directly.Changes
osal_socket_close()declaration toosal/osal.h.osal_socket_close()for:close()calls in:src/coap/coapclient.csrc/coap/coapserver.cosal_socket()to state that it returns a socket descriptor on success.Motivation
Socket creation is already abstracted through OSAL via
osal_socket(), but socket cleanup was still performed directly withclose().Adding
osal_socket_close()makes the socket lifecycle consistently platform-independent:This improves portability and keeps platform-specific socket handling inside the OSAL backend implementations.
Related issue
Fixes #47