provided client type for PCL to have proper telemetry

[vprysiaz]

No description provided.

[xorrkaz]

Thanks for this @vprysiaz . But all tests fail. Looks like an indentation issue. Moreover, will this work with PCL >= 2.8?

[xorrkaz]

And by work, I mean will it break PCL >= 2.8 if it's specified? If it is just ignored as a kwargs key, then that's fine.

[vprysiaz]

I will fix it today/tomorrow. yes. it is issue in pcl (we do not ignore kwargs...)
as an option we can update pcl version used here. or I will add version check to send this tag only when pcl is higher then version X

[xorrkaz]

For modernity, this should be "cmlutils"

[xorrkaz]

This looks good in general. I just had one request.

[xorrkaz]

You also still have an indentation issue. See the test results.

[vprysiaz]

You also still have an indentation issue. See the test results.

how to run them locally?
I did pytest tests/ and they all passed. indentation issue can be present as there was no linter run

[vprysiaz]

I wanna submit fix for a tag and indentation in one commit.

[coveralls]

Pull Request Test Coverage Report for Build 22954427290

Details

• 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.03%) to 78.588%

---

Totals
Change from base Build 22548103014:	0.03%
Covered Lines:	2070
Relevant Lines:	2634

---

💛 - Coveralls