Repository navigation
Serve assets through a Worker with AVIF resizing - #14
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 38e2123310
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f2162d17d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
MagicTheDev
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 53fadebabe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe4afad90d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7fdf98bdf5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
ClashKingAssets/assets/viewer.js
Line 81 in 6ba48af
Resolve relative manifest overrides against the page
When the override is a same-origin relative URL such as ?manifest=/staging/manifest.json, fetch(source) succeeds but new URL(entry.path, manifestUrl) throws because its base is not absolute, so the viewer fails instead of rendering the overridden catalog. Fresh evidence after the prior override fix is this absolute-base requirement introduced by the new URL construction; resolve manifestUrl against window.location.href before using it as the asset base.
ClashKingAssets/.github/workflows/check-assets-worker.yml
Lines 6 to 10 in 6ba48af
Trigger checks for generator source changes
A PR that changes only generate_manifest.py or update_static.py skips this workflow because neither file matches the path filter, even though the job is meant to validate manifest generation and this change adds translation-generation behavior. Such regressions can therefore merge without running the relevant Python checks; include these generator inputs in the workflow paths.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Assets were served directly from R2, so clients always received the stored file. This adds a Worker on
assets.clashk.ingthat keeps every existing URL working and can return resized AVIF images when requested.The release process now publishes a hashed manifest, uploads split translation files, and clears only the changed asset cache entries. Generated still WebP files are also normalized so they are not stored as animations.
The Worker is live on the production hostname using the existing
clashking-assetsbucket. Its purge token stays in Cloudflare and GitHub secrets.Checks