feat(bot): complete Worker migration and roster interactions - #131
Open
MagicTheDev wants to merge 7 commits into
Open
MagicTheDev wants to merge 7 commits into
MagicTheDev wants to merge 7 commits into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
archived/pythonand add the Cloudflare Worker runtime with signed Discord interactions, typed bindings, API client, and command routing./basepublishing and legacy button conversion through the API-owned message and media contract; preserve idempotent conversion recovery./linkto a token-required modal and retain/unlink, with localized help and error responses./rosterselection, views, signup/withdrawal, posting, and confirmation-based ping flows. Roster writes remain scoped to the invoking actor and signed interaction, with server-side API checks as the final authority.Contract inputs and limits
The Worker depends on the corresponding API and schema PRs for roster publication, linking, and automation behavior. The offline army-family output is descriptive research and cannot be copied into the durable schema without identity/cohort review. No deployment, production command registration, or live Discord signup validation is claimed by this PR.
Validation
worker: npm run check— 31 locales/95 keys, four command definitions, generated types, lint, TypeScript, 187 tests across 13 files, Wrangler dry-run build.research/army_family_local: python3 -m unittest test_prototype.py— four passed.git diff --checkpassed..dev.vars,.env.dev, and Python caches were excluded from commits.Current quality gate
SonarCloud was already failing on the full PR before this update: three findings in
archived/python/Dockerfile(S8541, S8544, S7018) and 12.55% duplicated lines on new code in its last completed analysis. The new push needs reanalysis. No rule, gate, or exclusion was changed to bypass these results; the archive's treatment needs a separate reviewed decision.