Fix ranking ingestion, preserve Warden mode, and schedule weekly rollover - #30
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Companion schema: ClashKingInc/DevKit#26. Companion API reader: ClashKingInc/ClashKingAPI#66. Populate both migration-020 materialized views before deploying the API reader. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 73df2ff71b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if !window.EndTime.After(floor) { | ||
| continue |
There was a problem hiding this comment.
Update the tagged test for the forward-only cutoff
When script_internal_tests is enabled—as it is by scripts/run-local-e2e.sh—this cutoff removes 2026-04 from the fixture in TestMissingCompletedLegendSeasonsUsesExactOfficialIDs, while that test still requires []string{"2026-04", v2Season}. The repository's local end-to-end command will therefore fail deterministically; update the existing test expectation or fixture to match the new forward-only behavior.
Useful? React with 👍 / 👎.
Changes
Dependencies and rollout
Requires ClashKingInc/DevKit#26 migration 020. Apply schema, deploy Tracking and verify populated views, then deploy the companion API reader. No production changes, restarts, migrations or merges performed.
Decisions
Routine history discovery uses a 35-day lookback or latest stored completion, whichever is later. Historical repair remains explicit. Missing Monday closeout blocks that week’s reset. Normal profile writers are not coordinated with the reset, as requested.
Validation
See docs/leaderboards.md and docs/scheduled.md for behavior and rollout details.