Repository navigation
feat(database): add share-code army families - #24
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Battle ingestion and family analytics currently require SHA-256 composition rows, while the approved pipeline identifies exact armies by canonical share code and stores only requested-player observations.
This adds a staged schema transition after migration 013:
The migration preserves existing representatives, names, assignments, old daily aggregates, attacks, and raw history. New code-only inserts do not calculate hashes or create composition rows.
Rollout is intentionally gated: apply 014, pause the old writer, complete the cleanup at Goose 14, apply 015, deploy compatible binaries, then resume ingestion. No production migration or cleanup was run.
Validation:
env GOCACHE=/tmp/clashking-army-schema-go-cache go test ./...node --test scripts/with-test-timescale.test.mjs scripts/with-test-integration.test.mjsgit diff --check