Normalize all Hebrew text to Unicode NFC#139
Closed
jonathanrobie wants to merge 1 commit into
Closed
Conversation
Reorders combining marks in @lemma, @unicode, @Transliteration, and element text content to Unicode canonical order (lower CCC first). For Hebrew, this means vowel points precede dagesh/shin-dot on the same consonant — the form produced by browsers, keyboards, and standard libraries. 929 node files updated. Lowfat and TSV will reflect the fix after regeneration from nodes. Adds python/normalize_nfc.py for future use if needed (e.g. after a new OSHB intake). Adds test_file_is_nfc to enforce NFC going forward. NFC normalization of raw XML text is safe: all XML structural characters are ASCII (combining class 0) and are unaffected. Closes #138 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Merged into PR #136 (fix/strip-cgj-from-lemmas) to reduce the number of PRs to merge. Both CGJ stripping and NFC normalization will ship together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #138.
Summary
WLC/nodes/*.xmlto Unicode NFC (929 files)@lemma,@unicode,@transliteration, and element text contentApproach
python/normalize_nfc.pyappliesunicodedata.normalize("NFC", ...)to the raw file text. This is safe for XML because all structural characters are ASCII (combining class 0) and are unaffected by NFC reordering.Test plan
test_file_is_nfcadded totest_nodes.py— enforces NFC on all node files going forwardpython/normalize_nfc.py --dry-runshould report 0 files after mergeWLC/nodes/*.xml🤖 Generated with Claude Code