fix/client: correctly parse SyncStatus::Error payload from Tauri event#26
Merged
fix/client: correctly parse SyncStatus::Error payload from Tauri event#26
Conversation
SyncStatus::Error(String) serializes as {"Error": "..."} in JSON via serde's
default enum representation. The frontend was assigning this object directly to
the store, causing SYNC_LABEL lookup to return undefined and the status to render
as blank.
- Normalize the payload in the sync-status listener, extracting the variant name
and error message separately
- Store syncErrorMessage in the general store (optional arg on setSyncStatus)
- Update tests to cover the error message round-trip
ClemPera
commented
Apr 14, 2026
The message was already logged by the backend. Sending it to the frontend had no good use: displaying it would spam on every sync cycle, and logging it on the frontend is redundant. Error is now a unit variant, serializing as the plain string "Error" like the other variants. This also removes the payload normalization workaround added in the previous commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SyncStatus::Error(String) serializes as {"Error": "..."} in JSON via serde's default enum representation. The frontend was assigning this object directly to the store, causing SYNC_LABEL lookup to return undefined and the status to render as blank.