fix(flac): write a valid last metadata block header - #113
Open
mathiiiiiis wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
FLAC files edited with
updateMetadataare rejected with "invalid block type 127"Cause
_writeBlockuses255 | blockId, which is0xFFfor anyblockIdand sets all seven type bits alongside the flag_parseMetadataBlockalso drops types 4 and 6, and regenerated blocks passisLastBlock: false, so files ending on a comment or picture carried no flag at allFix
write()emits headers after collecting all blocks, so the flag lands on the last one. Also keeps seek tables and writes ISO 8601 dates*Tests
New
test/writers/flac_writer_test.dart, run againstno_picture.flacand a newpicture_last.flacfixture. The first two failed onmainbeforeVerified on Android with
flac -t* I will split the date change into a separate commit from the block header fix if you'd prefer that (lib/src/writers/flac_writer.dart, 137)