Skip to content

Remove allocations#415

Merged
ph-kev merged 3 commits into
mainfrom
kp/allocs
Jul 17, 2026
Merged

Remove allocations#415
ph-kev merged 3 commits into
mainfrom
kp/allocs

Conversation

@ph-kev

@ph-kev ph-kev commented Jul 16, 2026

Copy link
Copy Markdown
Member

I asked Claude to find any easy fixes to allocations. The changes are not materializing vectors when constructing dictionaries, using more idiomatic functions like issetequal, and removing unnecessary copying.

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.49%. Comparing base (536ae4c) to head (9df7466).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #415   +/-   ##
=======================================
  Coverage   99.49%   99.49%           
=======================================
  Files          19       19           
  Lines        2181     2181           
=======================================
  Hits         2170     2170           
  Misses         11       11           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ph-kev
ph-kev requested a review from imreddyTeja July 16, 2026 21:06

@imreddyTeja imreddyTeja left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know any could be used like that. Left a nit about potential behavior change that might need documentation

Comment thread src/flat.jl
@ph-kev
ph-kev force-pushed the kp/allocs branch 2 times, most recently from 35748df to 26c4913 Compare July 17, 2026 18:55
@ph-kev
ph-kev merged commit 8c7199c into main Jul 17, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants