Reduce use of DataLayouts internals#1934
Merged
Merged
Conversation
charleskawczynski
force-pushed
the
ck/use_less_dl_internals
branch
2 times, most recently
from
August 15, 2024 02:17
b582ba3 to
8628c64
Compare
charleskawczynski
force-pushed
the
ck/use_less_dl_internals
branch
8 times, most recently
from
August 15, 2024 13:53
8c96331 to
2051e9b
Compare
charleskawczynski
marked this pull request as ready for review
August 15, 2024 13:53
charleskawczynski
force-pushed
the
ck/use_less_dl_internals
branch
3 times, most recently
from
August 15, 2024 15:15
0badf8c to
a6438d5
Compare
charleskawczynski
changed the title
Contributor
Author
|
I'll bump the allocation limits, but it looks like CI is otherwise passing. |
Sbozzolo
approved these changes
Aug 15, 2024
Sbozzolo
left a comment
Sbozzolo
left a comment
Contributor
There was a problem hiding this comment.
Look good to me, just a question
More changes
Contributor
Author
? |
Contributor
I thought I left a question in the review, but maybe I didn't click "submit". Upon re writing the question, I found the answer myself :) |
charleskawczynski
force-pushed
the
ck/use_less_dl_internals
branch
from
August 15, 2024 16:56
a6438d5 to
f474b57
Compare
This was referenced Aug 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically a peel off from #1929, and extends #1932. This PR:
parent(data)and especiallysize(parent(data))get_n_items, and instead only integers are passed (when needed)UniversalSizeto leverage static parameters moreDataLayouts.array_sizeandDataLayouts.farray_size, which return static sizes of the datalayouts (array_sizeuses a field dimension of 1, which is often helpful)This does increase some inference failures because I've passed some additional variables through to gpu kernels using
Val, which should result in statically known offsets, potentially improving performance of some kernels (likely by no more than 30%).