Drop field dimension, support linear indexing and empty fields#1953
Closed
charleskawczynski wants to merge 3 commits into
Closed
Drop field dimension, support linear indexing and empty fields#1953charleskawczynski wants to merge 3 commits into
charleskawczynski wants to merge 3 commits into
Conversation
charleskawczynski
marked this pull request as draft
August 23, 2024 00:49
charleskawczynski
force-pushed
the
ck/drop_field_dimension_support_empty_fields
branch
4 times, most recently
from
August 23, 2024 12:59
24ef689 to
52d84c0
Compare
Contributor
Author
|
Since they're working, here's the results for the CPU benchmarks: Main this PR
copyto! (DataF): 2 nanoseconds | 2 nanoseconds
copyto! (IJFH): 45 microseconds, 792 nanoseconds | 14 microseconds, 333 nanoseconds
copyto! (IFH): 23 microseconds, 250 nanoseconds | 3 microseconds, 510 nanoseconds
copyto! (VF): 8 nanoseconds | 7 nanoseconds
copyto! (VIJFH): 2 milliseconds, 219 microseconds | 1 millisecond, 440 microseconds
copyto! (VIFH): 402 microseconds, 750 nanoseconds | 286 microseconds, 417 nanosecondsfor the following parameters: FT = Float64
S = FT
Nf = 1
Nv = 63
Nij = 4
Nh = 30 * 30 * 6
Nk = 6Some cuda benchmarks are already summarized in #1910 and here |
charleskawczynski
force-pushed
the
ck/drop_field_dimension_support_empty_fields
branch
5 times, most recently
from
August 23, 2024 17:39
a0786fc to
c7fe195
Compare
charleskawczynski
force-pushed
the
ck/drop_field_dimension_support_empty_fields
branch
6 times, most recently
from
September 3, 2024 01:47
9ba577b to
dd7218d
Compare
Rename TupleOfArrays to FieldArrays Apply formatter wip Pass some unit tests, cleanup wip wip wip Apply formatter
charleskawczynski
force-pushed
the
ck/drop_field_dimension_support_empty_fields
branch
from
September 9, 2024 20:34
dd7218d to
a254113
Compare
Contributor
Author
|
Superseded by #2055. |
charleskawczynski
deleted the
ck/drop_field_dimension_support_empty_fields
branch
April 27, 2025 18:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #1929. I opened this just to preserve the previous branch/PR for convenience. This branch is probably more matured.
This CPU tests are nearly fully passing.
Remaining issues / items to revisit
field_namenow allocatesallowed_max_eps_errorchanges (perhaps just due to copied data?)field_array(array::AbstractArray, ::Type{T}) where {T <: AbstractData}if possibleFieldArrays) if possible) broken = Sys.iswindows()is this actually somehow fixed?column_field2array_viewcannot work butcolumn_field2arrayis fine. (column_field2array_viewis only used in the test dir)collectin writers:array = collect(parent(field)) # TODO: avoid collect heresingle_field_solver_cache(::UniformScaling, b) = similar(b, Tuple{})if possiblecolumn_field2array_viewand use copies in test suitetest/Fields/unit_field.jl)test/Fields/unit_field.jl)src/Operators/remapping.jl)