Hoist UniversalSize computation outside of kernels#2006
Merged
Conversation
charleskawczynski
force-pushed
the
ck/thread_partition_interface
branch
from
September 26, 2024 15:28
3d3eb74 to
a540321
Compare
Contributor
Author
|
I think that the case that broke is unrelated to this PR. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simply hoists computing the
UniversalSizecomputation outside of kernels and addsus::UniversalSizeobjects as an argument to some of the universal index functions, so that they're more flexible. This seems to be needed with both #2005 and #2002, so I'm peeling it off.