Skip to content

Change FH -> HF#2045

Closed
charleskawczynski wants to merge 1 commit into
mainfrom
ck/move_field_dim_to_end
Closed

Change FH -> HF#2045
charleskawczynski wants to merge 1 commit into
mainfrom
ck/move_field_dim_to_end

Conversation

@charleskawczynski

Copy link
Copy Markdown
Contributor

WIP to explore HF datalayouts.

@sriharshakandala

sriharshakandala commented Oct 17, 2024

Copy link
Copy Markdown
Contributor

I think this can happen naturally, with existing data layouts, by separating the storage for prognostic variables. This naturally restricts the NF to at most 3 (for example for velocity), except for passive scalars! The F dimension can be used for tuning most expensive kernels occuring in our workload rather than for collecting storage for all (cell-centered or face-centered) variables

@charleskawczynski
charleskawczynski force-pushed the ck/move_field_dim_to_end branch 6 times, most recently from c7687f0 to 82f145e Compare October 21, 2024 13:35
@charleskawczynski
charleskawczynski force-pushed the ck/move_field_dim_to_end branch 2 times, most recently from dbd418b to 6c15d08 Compare October 21, 2024 16:33
Swap F and H inds
@charleskawczynski

Copy link
Copy Markdown
Contributor Author

Superseded by #2055

@charleskawczynski

Copy link
Copy Markdown
Contributor Author

I think this can happen naturally, with existing data layouts, by separating the storage for prognostic variables. This naturally restricts the NF to at most 3 (for example for velocity), except for passive scalars! The F dimension can be used for tuning most expensive kernels occuring in our workload rather than for collecting storage for all (cell-centered or face-centered) variables

I'm not sure I follow this comment. This PR was changing the field dimension to the end in order to allow us to specialize on linear indexing for field variables without requiring users to change their code.

@charleskawczynski
charleskawczynski deleted the ck/move_field_dim_to_end branch April 27, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants