Skip to content

✨ feat: desktop#215

Open
SimonShiki wants to merge 41 commits into
dev/3.2from
desktop2
Open

✨ feat: desktop#215
SimonShiki wants to merge 41 commits into
dev/3.2from
desktop2

Conversation

@SimonShiki
Copy link
Copy Markdown
Member

@SimonShiki SimonShiki commented Apr 6, 2026 •
edited
Loading

Description

Add electron-based desktop application to monorepo.

Proposed Changes

  1. Create app/ at root to manage packages that used as applications and should not get published.
  2. Based on old clipcc-desktop to implement an electron-based desktop application implementation.
  3. Export gui's essential stuffs that needed for desktop
  4. Add webpack source root for gui
  5. Add include limit for block webpack config rules to made inheritance works
  6. Add workflow to build desktop cross-platform

Test Coverage

None

Additional Context

Pending alexcui03/rule-inheritance-webpack-plugin#1 get accepted and we can fix the inheritance issue if we're not in hoist mode

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Apr 6, 2026 •
edited
Loading

Deploying clipcc-preview with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8c3f98f
Status: ✅  Deploy successful!
Preview URL: https://9f6d4cf9.clipcc-preview.pages.dev
Branch Preview URL: https://desktop2.clipcc-preview.pages.dev

View logs

@SimonShiki
✨ feat: init desktop
1a80fb6 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki SimonShiki changed the base branch from dev/3.2 to feat/refined-gui-ts-support April 8, 2026 08:49
SimonShiki added 11 commits April 8, 2026 22:15
@SimonShiki
🔧 chore: made desktop runnable
d1e75d9 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
🔧 chore(desktop): implement dev server by ourselves
eaf43e3 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
🔧 chore: redo electron dev server
c13c75f 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
🔧 chore: add desktop gui hoc
90fa069 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
🚧 merge: update with feat/refined-gui-ts-support
43a694d 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
✨ feat: re-add multiple windows
08194f5 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
✨ feat(desktop): add bundle workflow
6742868 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
🔧 chore(desktop): reduce complexity
575f8e6 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
🐛 fix(desktop): add back save before exit dialog
48e3eaf 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
🐛 fix(desktop): add macos menu and custom ua
3e0e92c 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
🚧 merge: update with feat/refined-gui-ts-support
8d9525d 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@alexcui03
Copy link
Copy Markdown
Member

alexcui03 commented Apr 14, 2026 •
edited
Loading

Consider generating all images in buildResources of binary files from .svg by webpack? Maintaining non-text resources in git are bad, and it seems these PNGs and ICOs are generate by .svg initially.

Base automatically changed from feat/refined-gui-ts-support to dev/3.2 April 15, 2026 08:28
@SimonShiki
🚧 chore: update with dev/3.2
9f52621 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
🔧 chore: update with dev/3.2
76ee9d8 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
🔧 chore: add hot reload support for desktop
f027ade 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki SimonShiki marked this pull request as ready for review April 16, 2026 07:27
@SimonShiki
🐛 fix(render): include missing node polyfills
b139c91 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
🐛 fix(desktop): wrong host
94e164c 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
🔧 chore: add desktop build workflow
aabbfc8 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
🔧 chore(desktop): generate icons from svg
7fcecb4 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
🐛 fix(desktop): bundle dist recursively
397a296 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
🔧 chore(desktop): change email [ci skip]
eafed97 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki SimonShiki requested a review from alexcui03 April 16, 2026 14:56
@SimonShiki
🔧 chore(desktop): remove unneeded dirname alias
78dc489 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
🔧 chore: remove left esbuild onlyBuiltDependencies
0ab5b2f 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
alexcui03
alexcui03 requested changes Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@alexcui03 alexcui03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • generate existing .ico and .png from .svg before building, instead of maintaining them in repo.
  • README.md is missing

Comment thread app/desktop/src/renderer/routes/privacy/privacy.tsx Outdated
Comment thread app/desktop/src/renderer/routes/app/DesktopGUIHOC.tsx
Comment thread app/desktop/scripts/electron-builder-wrapper.mjs
Comment thread .github/workflows/desktop.yml Outdated
Comment thread app/desktop/buildResources/make-icons.sh Outdated
@SimonShiki
🔧 chore(desktop): rename dotenv file
41ff9ea 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
🔥 chore(desktop): remove unused make icons since we already write ano…
7543bee 
…ther

Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
🔧 chore(desktop): remove rebundant type inferrence
cf5d530 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
🔧 chore(desktop): hide privacy for now
9b8eb67 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
📦 chore(desktop): fix ghost dependency
783bbef 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
📝 docs(desktop): add readme
b3d2065 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
👷 chore: build desktop when prereleased
c846aef 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki SimonShiki requested a review from alexcui03 April 18, 2026 01:03
@SimonShiki SimonShiki self-assigned this Apr 18, 2026
@SimonShiki
🔥 chore(desktop): remove all import.meta.* alias
a02ed48 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
🔥 chore(desktop): remove unused assets
8d4c0d9 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki SimonShiki added feature New feature or request gui Things related to clipcc-gui. labels Apr 19, 2026
SimonShiki and others added 9 commits April 19, 2026 14:55
@SimonShiki
🚧 merge: update with dev/3.2
4809c67 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
🔧 chore(desktop): generate cc3 icon from svg file
409875b 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
🔥 chore(desktop): remove all privacy usage
52a719e 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki @SoilZhu
🔧 chore(desktop): use soil version cc3 icon
71e413b 
Co-authored-by: Soil <soilland@yandex.com>
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
🔧 chore: import react tabs from gui
bdd5880 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki @SoilZhu
🍱 chore(desktop): add ccx icon
841a9d2 
Co-authored-by: Soil <soilland@yandex.com>
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
🔧 chore(desktop): redirect babel-loader cwd
2f7dcc2 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
🔧 chore: add missing gitignore & node polyfills plugin
bd52bc1 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
🔧 chore(desktop): add missing dependencies
8c3f98f 
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcui03 alexcui03 Awaiting requested review from alexcui03

Requested changes must be addressed to merge this pull request.

Assignees

@SimonShiki SimonShiki

Labels

feature New feature or request gui Things related to clipcc-gui.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SimonShiki @alexcui03