-
Notifications
You must be signed in to change notification settings - Fork 1
🚚 chore(vm): migrate to typescript part 1 #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SimonShiki
wants to merge
30
commits into
feat/esm-vm
Choose a base branch
from
feat/ts-vm
base: feat/esm-vm
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
ddc7ff3
:wrench: chore(vm): convret util to be ts
SimonShiki 9c129b1
:wrench: chore(vm): migrate some engine stuffs to typescript
SimonShiki b9655b8
:bug: fix(vm): correct reference
SimonShiki f2151c1
:wrench: chore(vm): migrate engine/variable
SimonShiki 1c6cdcd
:wrench: chore(vm): migrate engine/adapter
SimonShiki e456e21
:fire: chore(vm): remove mutation adapter
SimonShiki 30accb3
:wrench: chore(vm): migrate profiler
SimonShiki 0d5b4a1
:rewind: revert: ":fire: chore(vm): remove mutation adapter"
SimonShiki a50ef86
:wrench: chore(vm): migrate mutation adapter
SimonShiki 6381752
:bug: fix(vm): dts generation strategy
SimonShiki 8e9c619
:wrench: chore(vm): migrate some io adapters
SimonShiki 13c08d1
:wrench: chore(vm): migrate dispatchers
SimonShiki 4686765
:bug: fix(vm): tests except worker-related issues
SimonShiki 287d983
:art: chore(vm): fix lint
SimonShiki d3e5f90
:art: chore(vm): fix lint
SimonShiki 00508b1
:bug: fix(vm): run ts worker in same process
SimonShiki 37f73ca
:wrench: chore(vm): migrate scratch3_control category
SimonShiki b5a85fb
:wrench: chore(vm): migrate some categories
SimonShiki 1032c03
:wrench: chore(vm): migrate left categories
SimonShiki 331a33a
:wrench: chore(vm): migrate sprite.js
SimonShiki 016e831
:wrench: chore(vm): migrate thread.js
SimonShiki b799478
:wrench: chore(block): migrate block-utility
SimonShiki 80c5bf3
:art: chore(vm): lint fix
SimonShiki e19802d
:bug: fix: build and tests
SimonShiki e7c2ff9
:bug: fix(vm): missing util mock
SimonShiki c6050e7
:wrench: chore(vm): migrate sequencer
SimonShiki f8f34a1
:beers: fix(vm): accidentally change clone logic
SimonShiki 61d5dd0
:bug: fix(vm): inconsistent behavior
SimonShiki 47baeb8
:wrench: chore(vm): export schema
SimonShiki c57f136
:wrench: chore(vm): fix build
SimonShiki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| /* eslint-disable @typescript-eslint/no-explicit-any */ | ||
| import type BlockUtility from '../engine/block-utility'; | ||
| import type {HatMetadata, MonitorBlockInfo} from '../engine/runtime'; | ||
|
|
||
| export type BlockArgs = { | ||
| [argName: string]: any; | ||
| mutation?: Record<string, any>; | ||
| } | ||
|
|
||
| export type BlockFunction = (args: BlockArgs, util: BlockUtility) => any; | ||
|
|
||
| export interface CategoryPrototype { | ||
| /** | ||
| * Retrieve the block primitives implemented by this package. | ||
| * @returns Mapping of opcode to Function. | ||
| */ | ||
| getPrimitives(): Record<string, BlockFunction>; | ||
| getHats?(): Record<string, HatMetadata>; | ||
| getMonitored?(): Record<string, MonitorBlockInfo>; | ||
| getOrders?(): Record<string, (string | {execute: string})[]>; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test types should also get resolved if they use ts.