Skip to content
This repository was archived by the owner on Jul 1, 2020. It is now read-only.

Add bullet decals#26

Open
Elkien3 wants to merge 3 commits intoClobberXD:masterfrom
Elkien3:patch-8
Open

Add bullet decals#26
Elkien3 wants to merge 3 commits intoClobberXD:masterfrom
Elkien3:patch-8

Conversation

@Elkien3
Copy link
Copy Markdown
Contributor

@Elkien3 Elkien3 commented Mar 27, 2019

untested with this fork, but worked fine in mine.

Elkien3 added 2 commits March 27, 2019 08:12
need to get the texture too
made it myself
@ClobberXD
Copy link
Copy Markdown
Owner

The markings aren't showing up if the intersection point is on top of a node. Otherwise, very cool feature. 👍

@Elkien3
Copy link
Copy Markdown
Contributor Author

Elkien3 commented Mar 27, 2019

Could remove vertical = true, though it won't look as nice on the sides of nodes

@ClobberXD
Copy link
Copy Markdown
Owner

Maybe check if surface is horizontal or vertical, and then set the vertical field accordingly?

Comment thread api.lua Outdated
@ClobberXD
Copy link
Copy Markdown
Owner

@Elkien3 Hey, are you around? Would you be able to attend to this PR? The following is all that remains:

Maybe check if surface is horizontal or vertical, and then set the vertical field accordingly?

There's not much left to do, really. :)

@ClobberXD ClobberXD added the Changes requested ❕ This PR isn't mergeable in its current state, or changes have been requested by the reviewer. label May 2, 2020
@ClobberXD
Copy link
Copy Markdown
Owner

I'll adopt this PR.

Maybe check if surface is horizontal or vertical, and then set the vertical field accordingly?

This can easily be checked using the intersection_normal field in pointed_thing.

@ClobberXD ClobberXD self-assigned this May 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Adoption needed Changes requested ❕ This PR isn't mergeable in its current state, or changes have been requested by the reviewer. Feature New feature ⚙️ Mechanics ⚙️ Textures / Sounds

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants