feat: validate transaction-level locks require active transaction

[seuros]

Prevent silent failures when transaction: true is used outside transactions

closes #74

[Copilot]

Pull Request Overview

Adds a guard to prevent silent failures when transaction: true is used outside of an active database transaction by raising an error, along with new tests to verify this behavior for both PostgreSQL and MySQL.

• Add validation in the advisory lock core to enforce active transactions
• Add tests for both PostgreSQL and MySQL to assert the error is raised when no transaction is open

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
lib/with_advisory_lock/core_advisory.rb	Inserts a runtime check to raise ArgumentError if transaction: true is used without an active transaction
test/with_advisory_lock/transaction_test.rb	Adds two new tests (PostgreSQL and MySQL) to assert the error is raised outside of transactions; refactors a test block’s exception message

Comments suppressed due to low confidence (1)

lib/with_advisory_lock/core_advisory.rb:21

• The call to transaction_open? may not be defined in this context. Consider using a method on the connection (e.g., ActiveRecord::Base.connection.open_transactions > 0) or explicitly delegating the call to ensure it’s available.

      if options.fetch(:transaction, false) && !transaction_open?

[Copilot]

[nitpick] The whimsical exception message in this test could be confusing for future maintainers. It may be clearer to simplify it to something like raise 'should not reach this code' for consistency with the PostgreSQL test.

Suggested change

	raise 'Behold! Thou hath trespassed into the sacred MySQL transaction realm!'
	raise 'should not reach this code'