Correcting window size for mass averages. #73
Merged
Merged
Conversation
elenagonzalez870
commented
May 8, 2026
elenagonzalez870
commented
Contributor
- Currently, the local squared mass averages are calculated within a window that is either AVEKERNEL or 1.0e-4 * ((double) clus.N_STAR) / 2.0. For clusters with a large number of stars, this means that mass averages are computed over a window containing thousands of neighbors. This is inconsitent with the fact that other averaged local quantities (like calc_n_local) are always calculated in a fixed window, and it is likely just legacy code that was never changed.
…window that is either AVEKERNEL or 1.0e-4 * ((double) clus.N_STAR) / 2.0. For clusters with a large number of stars, this means that mass averages are computed over a window containing thousands of neighbors. This is inconsitent with the fact that other averaged local quantities (like calc_n_local) are always calculated in a fixed window, and it is likely just legacy code that was never changed.
There was a problem hiding this comment.
Pull request overview
This PR updates the neighbor-window selection used when computing the local average of mass², making it consistently use the fixed AVEKERNEL window size instead of scaling with clus.N_STAR.
Changes:
- Set the averaging half-window
pincalc_average_mass_sqr()to always beAVEKERNEL(removing theMAX(1e-4*N_STAR/2, AVEKERNEL)scaling).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
looks good to me! |
carlrodriguez
self-requested a review
May 25, 2026 17:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.