Repository navigation
Fix ComposabilityRequest webhook validator for controller-runtime API - #46
Merged
hase1128 merged 2 commits intoJul 10, 2026
Merged
Conversation
NekoHK
requested review from
hase1128,
mgazz,
shogom2 and
tmkymst
as code owners
July 10, 2026 04:46
Signed-off-by: Ko Kai <ko.kai@jp.fujitsu.com>
Signed-off-by: Ko Kai <ko.kai@jp.fujitsu.com>
NekoHK
force-pushed
the
fix/typed-composabilityrequest-validator
branch
from
July 10, 2026 04:47
e776cf5 to
bf7dde9
Compare
shogom2
approved these changes
Jul 10, 2026
hase1128
approved these changes
Jul 10, 2026
Collaborator
|
@mgazz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ComposabilityRequestwebhook validator to the typedadmission.ValidatorinterfaceWhy
The previous webhook implementation used the deprecated untyped
webhook.CustomValidatorinterface and was incompatible with the current controller-runtime API.Additionally, controller-tools v0.16.1 depended on an older
golang.org/x/toolsversion that could not compile with Go 1.26.