feat: add codspeed benchmarks for valgrind#5
Merged
not-matthias merged 1 commit intomasterfrom Nov 5, 2025
Merged
Conversation
1f4889c to
e4d12af
Compare
0da4e3a to
7ab484a
Compare
fce6155 to
e16a7f8
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a benchmarking infrastructure for Valgrind using pytest-codspeed and GitHub Actions. It enables performance tracking across different Valgrind versions and configurations.
- Adds a Python-based benchmarking script that uses pytest-codspeed to profile Valgrind with different configurations
- Creates GitHub Actions workflow for automated benchmarking with multiple Valgrind versions and test commands
- Implements caching and build optimization for Valgrind in CI/CD pipelines
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| bench/bench.py | Main benchmarking script with ValgrindRunner class and pytest integration for profiling Valgrind |
| bench/pytest.ini | Pytest configuration to exclude test data directories from discovery |
| bench/testdata/* | Git LFS pointer files for binary test data (test.py and architecture-specific binaries) |
| Justfile | Build automation recipes for downloading, building, and installing specific Valgrind versions |
| .github/workflows/codspeed.yml | GitHub Actions workflow for running benchmarks across matrix of commands and Valgrind versions |
| .github/workflows/ci.yml | Updated CI workflow to skip installing package documentation for faster builds |
| .gitattributes | Git LFS configuration for binary test data files |
Comments suppressed due to low confidence (4)
bench/bench.py:11
- Import of 'os' is not used.
import os
bench/bench.py:14
- Import of 'sys' is not used.
import sys
bench/bench.py:15
- Import of 'Path' is not used.
from pathlib import Path
bench/bench.py:16
- Import of 'time' is not used.
import time
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e16a7f8 to
f16dd47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.