-
Notifications
You must be signed in to change notification settings - Fork 0
[SSF-111] food manufacturer application frontend #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ad221d0 to
3a51d9b
Compare
61e2068 to
a3f6c59
Compare
dburkhart07
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very small things, after this should be good!!!!
| <Text {...sectionTitleStyles}>Product Details</Text> | ||
| <Field.Root required mb="2em"> | ||
| <Field.Label {...fieldHeaderStyles}> | ||
| Which allergen(s) are not listed in your products' ingredients? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: This is supposed to be "What" instead of "Which"
| )} | ||
| </Field.Root> | ||
|
|
||
| <Field.Root required mb="2em"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this mb should be 3em to match the Figma (it seems like there is a little more space between this field component and the next)
| Are you: | ||
| </Field.Label> | ||
| <NativeSelect.Root> | ||
| <NativeSelect.Field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text for this seems a little big. Can we change it to match the "Select allergens" placeholders from the dropdowns above in the component?
ℹ️ Issue
Closes #111
📝 Description
✔️ Verification
Verified submission of application added manufacturer to local db.

🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!