[SSF-114] Remove Order–Pantry Relationship #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dburkhart07
requested changes
Jan 26, 2026
| } | ||
|
|
||
| async findOrderPantry(orderId: number): Promise<Pantry> { | ||
| validateId(orderId, 'Order'); |
There was a problem hiding this comment.
Why did we delete this validation?
| const qb = this.repo | ||
| .createQueryBuilder('order') | ||
| .leftJoinAndSelect('order.pantry', 'pantry') | ||
| .leftJoinAndSelect('order.request', 'request') |
There was a problem hiding this comment.
This current call when I tested it returned no info on the volunteers or pantry. With this relation being removed, however, I wonder if we still even need them. Can you check with Sam on this, and whether we even still want the pantryNames aspect of the filter, or just reclarify what fields we would want this endpoint to return?
|
|
||
| describe('findOrderPantry', () => { | ||
| it('should return pantry for given order', async () => { | ||
| const mockFoodRequest = { |
There was a problem hiding this comment.
Can we type each of these as partials?
| }); | ||
|
|
||
| it('should throw NotFoundException if pantry not found', async () => { | ||
| const mockFoodRequest = { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes SSF-114
📝 Description
✔️ Verification
Make sure all tests passed and verified updated endpoints on Postman.
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!