Fix detect_repo() picking upstream over origin in fork setups - #1
Merged
Merged
Conversation
gh repo view resolves the "current" repo from all configured remotes, and when a fork also has an upstream remote pointing at the parent repo, gh can silently pick upstream instead of origin -- causing the skill to operate on the wrong repo entirely (wrong PR numbers, wrong comment/issue targets). Read the origin remote's URL directly instead, falling back to gh repo view only if origin is missing or not GitHub.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
detect_repo()inopen_comments.pyrelied ongh repo view, which resolves the "current" repo from all configured git remotes. When a fork also has anupstreamremote,ghcan silently pickupstreaminstead oforigin, causing the skill to operate on the wrong repo (wrong PR numbers, wrong comment/issue targets).originremote's URL directly (supports both SSH and HTTPS GitHub URLs) and fall back togh repo viewonly iforiginis missing or isn't a GitHub remote.Test plan
git@github.com:owner/repo.gitandhttps://github.com/owner/repo(.git)formsdetect_repo()in this repo (which itself has a fork/upstream-style remote setup) and confirmed it resolves toorigincorrectly