This repository was archived by the owner on Oct 1, 2022. It is now read-only.
Move the password validation server side - #185
Open
kerimhudson wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a volunteer, I'm not totally comfortable with the way in which authentication is currently handled on the front-end. The password is hard-coded into the frontend and is visible and easy to access by viewing the source code, which then reveals the email addresses of all the volunteers.
As there's already a backend integration for this app, it would be better to store the password as an ENV variable to make it easier to change in the future, and so that it can't be read from the frontend.
This is an example of how this logic could be integrated, however this was done without a DB connection so there may be errors.