Skip to content

Conversation

@khalidbih
Copy link

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I created the Wireframe project page with three articles explaining README, Wireframe, and Git branches. Footer is fixed, and CSS is linked.

@khalidbih khalidbih added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Jan 20, 2026
@netlify
Copy link

netlify bot commented Jan 20, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit e2203d9
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/696ff2afd0a27c000845e515
😎 Deploy Preview https://deploy-preview-997--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 96 (🔴 down 4 from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@jenny-alexander jenny-alexander self-requested a review January 26, 2026 23:53
@jenny-alexander jenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jan 26, 2026
Copy link
Contributor

@jenny-alexander jenny-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @khalidbih - nice job getting your PR created with your exercise submission! Your wireframe webpage looks very good. I see a few places to improve upon.

  • Can you run your webpage through https://validator.w3.org/? I see an error that should be fixed.
  • Can you please replace the placeholder.svg image with an image that is related to the article?
  • Can you review the footer styling? Currently is overlapping on the 'Read more' buttons and cutting them off a little bit.
Screenshot 2026-01-26 at 9 31 47 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Onboarding The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants