-
-
Notifications
You must be signed in to change notification settings - Fork 87
London | 26-SDC-MAR | Jamal Laqdiem | Sprint 3 | Implement Shell Tools #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
276fc2b
8675a8b
99cb233
e1d7c80
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| .venv |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import process from "node:process"; | ||
| import { promises as fs } from "node:fs"; | ||
|
|
||
| // THis will give an array without the path to node and to the file. | ||
| const argv = process.argv.slice(2); | ||
|
|
||
| //Get line numbers. | ||
| const showNumbers = argv.includes("-n"); | ||
| const showNonBlankNumbers = argv.includes("-b"); | ||
|
|
||
| //filter the - from the array argv as it's a flag. | ||
| const filePaths = argv.filter((arg) => !arg.startsWith("-")); | ||
|
|
||
| const flagsUsed = argv.filter((arg) => arg.startsWith("-")); | ||
| const supportedFlags = ["-n", "-b"]; | ||
| for (const flag of flagsUsed) { | ||
| if (!supportedFlags.includes(flag)) { | ||
| console.error(`Invalid option try 'node cat.js --help' for more info.`); | ||
| process.exit(1); | ||
| } | ||
| } | ||
|
|
||
| let counterLines = 1; | ||
|
|
||
| for (const path of filePaths) { | ||
| try { | ||
| const content = await fs.readFile(path, "utf-8"); | ||
|
|
||
| //split the text at the new line character. | ||
| const splitLines = content.split("\n"); | ||
|
|
||
| splitLines.forEach((line) => { | ||
| let prefix = ""; | ||
|
|
||
| if (showNonBlankNumbers) { | ||
| if (line.trim() !== "") { | ||
| prefix = `${counterLines++} `; | ||
| } | ||
| } else if (showNumbers) { | ||
| prefix = `${counterLines++} `; | ||
| } | ||
| console.log(`${prefix}${line}`); | ||
| }); | ||
| } catch (error) { | ||
| console.error(`Could not read: ${path}`); | ||
| process.exit(1); | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import fs from "node:fs"; | ||
| import process from "node:process"; | ||
|
|
||
| // This will give an array without the path to node and to the file. | ||
| const argv = process.argv.slice(2); | ||
|
|
||
| // filter the flag to find the target folder. | ||
| const filePaths = argv.filter((arg) => !arg.startsWith("-")); | ||
| const showHiddenFiles = argv.includes("-a"); | ||
|
|
||
| if (filePaths.length > 1) { | ||
| console.error("Error: This version only supports one directory path a time."); | ||
| process.exit(1); | ||
| } | ||
| // if no folder provide we use the current one | ||
| const target = filePaths[0] || "."; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What would happen if someone specified multiple paths, e.g. The README.md only requires that your programme works with simple paths, but I would recommend implementing support for multiple. But if you don't implement that, you generally want to give an error to the user if they supply input you don't expect, rather than just ignoring it.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for reviewing, I should at least display an stderr and exit . |
||
| // read the file. | ||
| const files = fs.readdirSync(target); | ||
|
|
||
| // save the result into the variable. | ||
| let filteredFIles = files; | ||
| if (!showHiddenFiles) { | ||
| filteredFIles = files.filter((file) => !file.startsWith(".")); | ||
| } else { | ||
| // we use spread operator to merge the paths. | ||
| filteredFIles = [".", "..", ...files]; | ||
| } | ||
|
|
||
| // Print using -1 . | ||
| filteredFIles.forEach((file) => { | ||
| console.log(file); | ||
| }); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import process, { exit } from "node:process"; | ||
| import fs from "node:fs"; | ||
|
|
||
| const argv = process.argv.slice(2); | ||
|
|
||
| let showWords = argv.includes("-w"); | ||
| let showLines = argv.includes("-l"); | ||
| let showBytes = argv.includes("-c"); | ||
| let showCharacters = argv.includes("-m"); | ||
|
|
||
| // filter flags, and getting the string of filename | ||
| const filePaths = argv.filter((arg) => !arg.startsWith("-")); | ||
| // if no flags enable all. | ||
| if (!showLines && !showCharacters && !showWords && !showBytes) { | ||
| showLines = true; | ||
| showCharacters = true; | ||
| showWords = true; | ||
| showBytes = true; | ||
| } | ||
| // fix bug .length ===0 will be true if nothing provided, instead !filePath will return empty array which result true. | ||
| if (filePaths.length === 0) { | ||
| console.error("PLease provide a file path"); | ||
| process.exit(1); | ||
| } | ||
| // loop trough the array to get each file path. | ||
| filePaths.forEach((filePath) => { | ||
| const content = fs.readFileSync(filePath, "utf-8"); | ||
|
|
||
| const lines = content.split("\n").length - 1; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do you have to
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for reviewing, I used -1 because my vscode automatically add a new line when save, so in this case split method will add an empty element, however in other environments this logic my fail if no trialling new line added .
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We may add a conditional check using .pop method in case of empty string at the end |
||
| const words = content | ||
| .trim() | ||
| .split(/\s+/) | ||
| .filter((word) => word != "").length; | ||
| // here I used Buffer.byteLength even if characters and bytes can be the same number .length, however sometimes an emoji or special characters can be heavier 2b or 4b | ||
| const bytes = Buffer.byteLength(content); | ||
| const characters = content.length; | ||
|
|
||
| let output = ""; | ||
|
|
||
| if (showLines) output += `${lines} `; | ||
| if (showWords) output += `${words} `; | ||
| if (showBytes) output += `${bytes} `; | ||
| if (showCharacters) output += `${characters} `; | ||
|
|
||
| console.log(`${output} ${filePath}`); | ||
| }); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would happen if someone passed a
-qflag here? What should happen?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing, you are right to point that out, my logic will let the user confused thinking that the -q flag exists and worked, I implemented in place a flag check and ensured print an error and exit with not 0 code.