Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{
"title": "feat(cli): add Windows toast notification for task completion",
"head": "rekty:feat/desktop-notification",
"base": "main",
"body": "Closes #1111\n\nWhen speakers are muted or the user steps away, the terminal bell (BEL character in the OSC title sequence) is easy to miss. This adds a native Windows toast notification that fires when a run completes so users always get a visual cue.\n\n### Changes\n\n-
cli/src/utils/notification.ts(new) —notifyDesktop(title, body)uses .NETToastNotificationManagervia PowerShell. Works on every Windows 10+ machine without extra dependencies. Falls back gracefully on any error.notifyTaskComplete(agentName?)is the convenience wrapper.\n-cli/src/hooks/helpers/send-message.ts— callsnotifyTaskComplete()afterfinalizeQueueStateon successful completion.\n\n### Platform behavior\n\n| Platform | Notification |\n|---|---|\n| Windows | Native toast (via PowerShell .NET interop) |\n| macOS / Linux | No-op (terminal bell already provides the cue) |\n\nThe Desktop (Electron) app can also importnotifyTaskCompletedirectly for its own completion events.\n\n### Verification\n\n-bun test cli/src/hooks/helpers/__tests__/send-message.test.ts— pre-existing failure (missingweb-tree-sitterdep), unrelated to this change\n-notification.tsis self-contained with no external dependencies"}