You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Recreated on the rewritten main after #1101 was auto-closed during repository maintenance. This carries the same reviewed change set on the new history.
Summary
derive git commit attribution from the compile-time FREEBUFF_MODE flag
keep Codebuff's existing footer for standard builds
use Freebuff branding and domain for Freebuff binaries
common full test command: 1,158 passed; 37 existing checkout/snapshot failures remain in unrelated web/agent sources and one existing Zod schema expectation
agent-runtime typecheck: existing missing agents-graveyard/researcher/researcher imports; no errors from changed files
Good, scoped fix: run-terminal-command.ts's commit-footer text was hardcoded to "Codebuff" even in Freebuff builds. This PR introduces getGitCommitGuidePrompt(isFreebuff) that derives the product name/domain from FREEBUFF_MODE, keeps the existing gitCommitGuidePrompt export for backward compatibility, and updates the native-tool-call example string to use the same attribution. Tests in run-terminal-command-branding.test.ts cover both the default (Codebuff) and Freebuff paths without needing to mutate process.env, which is the right approach for testability.
A couple of minor things worth tightening before porting:
buildCommitAttribution / commitProductName / commitProductDomain (lines ~150-153) recompute getCommitAttribution(isFreebuffBuild) a second time when getGitCommitGuidePrompt() already computed it internally for the default prompt. Not a bug, but redundant - could just call getCommitAttribution(isFreebuffBuild) once at module scope and reuse it in both places.
The CommitAttribution type hardcodes the literal domains/names as a union of two values, which works but will need updating if a third product/build variant is ever added - fine for now given the two-build reality.
Overall this is a clean, single-purpose fix with regression coverage, touches only common/, and should be straightforward to port by hand.
Tightened the redundant attribution lookup. The default getGitCommitGuidePrompt() path now reuses the module-level build attribution; explicit boolean calls still compute the requested product so the testable API remains intact. Targeted branding tests: 2 passed, 0 failed; git diff --check passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FREEBUFF_MODEflagFixes #997
Validation
Prior validation before the history rewrite:
git diff --check: passedagents-graveyard/researcher/researcherimports; no errors from changed files