fix: add linux-x64-baseline and win32-x64-baseline target mappings to build script - #1255
fix: add linux-x64-baseline and win32-x64-baseline target mappings to build script#1255err0x420 wants to merge 1 commit into
Conversation
Adds missing linux-x64-baseline mapping to enable non-AVX baseline builds.
|
This is a small, targeted change that adds A few things worth checking before porting:
Overall the change itself is small, in-scope, and plausible - worth a maintainer's time to verify against the actual Bun target list and port. |
|
Hi @codebuff-team! After confirming the upstream Bun engine constraints, I’m going to close this PR. Even with baseline targets, Bun-compiled binaries target the Nehalem (SSE4.2) microarchitecture as their absolute baseline. As a result, CPUs limited to SSE4.1, such as the Core 2 Quad Yorkfield, still raise Therefore, mapping the baseline targets in Thanks for taking the time to review this PR and for the helpful feedback! |
Re-opening PR #814 following the repository history rewrite, as requested by maintainers.
Summary
Adds the missing
'linux-x64-baseline'and'win32-x64-baseline'target mappings tocli/scripts/build-binary.ts. This allows the build pipeline to properly resolve and output baseline binaries for older x86-64 CPUs on both Linux and Windows.Details & Verification
'linux-x64-baseline'(mapping to'bun-linux-x64-baseline') and'win32-x64-baseline'(mapping to'bun-windows-x64-baseline') undergetTargetInfo().bun-linux-x64-baselineandbun-windows-x64-baselineare valid compile targets (accepted for backward compatibility and mapped to x64 Nehalem/SSE4.2 baseline targets).index.js) already expectsfreebuff-linux-x64-baseline.tar.gzandfreebuff-win32-x64-baseline.tar.gzartifacts when fallback triggers orFREEBUFF_BINARY_TARGETis set. Without these mappings inbuild-binary.ts,getTargetInfo()throws an unsupported target error during the build phase.Related Context & Issues