Updated tailwind import behavior#2776
Open
girishpanchal30 wants to merge 1 commit intodevelopmentfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts Atomic Wind’s Tailwind compilation entrypoint to reduce unintended style precedence and improve compatibility with existing site styles.
Changes:
- Removes the
importantmodifier from the Tailwind@importused by the in-browser Tailwind compiler.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@girishpanchal30 I dont think this is the rigth solution, this might break some other stuff, will leave @abaicus to evaluate it |
Contributor
Bundle Size Diff
|
Contributor
|
Plugin build for 71f82d0 is ready 🛎️!
|
Contributor
E2E TestsPlaywright Test Status: Performance ResultsserverResponse: {"q25":359.9,"q50":364.85,"q75":393.5,"cnt":10}, firstPaint: {"q25":381,"q50":437.05,"q75":468.3,"cnt":10}, domContentLoaded: {"q25":1590,"q50":1605.25,"q75":1614,"cnt":10}, loaded: {"q25":1590.4,"q50":1605.55,"q75":1614.6,"cnt":10}, firstContentfulPaint: {"q25":3266,"q50":3282.25,"q75":3292.3,"cnt":10}, firstBlock: {"q25":6532,"q50":6607.4,"q75":6673.8,"cnt":10}, type: {"q25":13.42,"q50":13.89,"q75":14.63,"cnt":10}, typeWithoutInspector: {"q25":12.3,"q50":12.45,"q75":13.8,"cnt":10}, typeWithTopToolbar: {"q25":16.18,"q50":16.61,"q75":17.45,"cnt":10}, typeContainer: {"q25":7.44,"q50":7.66,"q75":8.62,"cnt":10}, focus: {"q25":54.76,"q50":57.97,"q75":61.33,"cnt":10}, inserterOpen: {"q25":16.77,"q50":17.39,"q75":17.78,"cnt":10}, inserterSearch: {"q25":5.84,"q50":5.97,"q75":6.06,"cnt":10}, inserterHover: {"q25":3.15,"q50":3.24,"q75":3.56,"cnt":20}, loadPatterns: {"q25":1031.8,"q50":1082.91,"q75":1115.59,"cnt":10}, listViewOpen: {"q25":89.71,"q50":92.24,"q75":95.75,"cnt":10} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Codeinwp/otter-internals/issues/271
Summary
Adjusted Tailwind import behavior to avoid aggressive style overrides and ensure better compatibility with existing styles.
Checklist before the final review