ping Slack #tabs-vs-spaces when E2E tests fail - #269
Merged
Conversation
NejcS
marked this pull request as ready for review
July 31, 2026 09:00
NejcS
changed the title
hisenb3rg
reviewed
Aug 10, 2026
hisenb3rg
left a comment
hisenb3rg
left a comment
Contributor
There was a problem hiding this comment.
Yo,
I've asked my agent and brought some suggestions up, I think they make sense:
- Repo already has the safe pattern — reuse it. nofity-slack-on-main-merge.yml:15-22 uses slackapi/slack-github-action@v1.24.0 toJSON(format(...)). That gets you correct escaping, no injection, and non-2xx → job failure, for free. Hand-rolled curl is a regression from your own convention.
- Message doesn't say which platform failed. Two jobs in needs; you get pinged and still have to open the run. Add needs.*.result.
- Missing newline at EOF. Commit fixed the old one and introduced a new one.
Contributor
Author
|
All 3 make sense, thanks. |
NejcS
force-pushed
the
worktree-e2e-slack-notify
branch
from
August 17, 2026 09:17
db65b02 to
35ffb68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
notify-on-failurejob toe2e.ymlthat posts to Slack #tabs-vs-spaces whenever the Linux or Windows E2E job fails. Guarded on the newSLACK_E2E_WEBHOOK_URLsecret (couldn't reuse the other one since it's for the wrong channel), so repos without it are unaffected. Follows thecurlpattern from #268.