fix: check for git before verifying the installation - #274
Merged
zanjonke merged 1 commit intoAug 6, 2026
Conversation
The installers run `codeplain --status` to verify the setup, but the CLI imports GitPython, which fails at import time when the git executable is missing. Users without git saw a raw Python traceback ending in GitNotInstalledError, followed by advice to restart the terminal or reinstall -- neither of which fixes a missing git. Check for git alongside the existing uv check, before any prompts or package installs, and exit with the platform's install URL. Verify that git actually runs rather than trusting a resolvable name, since a stale shim can satisfy the lookup without a working git behind it. This complements the CLI-side GitNotInstalledError already on main: the installer now stops before that error can surface, and the friendly CLI error remains the fallback for anyone who bypasses the installer. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #272