Build the git-detected check mark from its code point - #276
Open
sunasrd-byte wants to merge 1 commit into
Open
Conversation
install.ps1 is UTF-8 without a BOM, so Windows PowerShell 5.1 decodes it as CP1252, where the literal U+2713 on the "git detected" line becomes a smart quote that terminates the enclosing string. The script then fails to parse and installs nothing; only `irm ... | iex` was unaffected, since that decodes as UTF-8 over HTTP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install.ps1 is UTF-8 without a BOM, so Windows PowerShell 5.1 decodes it
as CP1252, where the literal U+2713 on the "git detected" line becomes a
smart quote that terminates the enclosing string. The script then fails
to parse and installs nothing; only
irm ... | iexwas unaffected, sincethat decodes as UTF-8 over HTTP.