plain-forge rules review and fixing - #17
Open
dusano wants to merge 14 commits into
Open
Conversation
… is preferred convention and not a rule.
…was introducing confusion.
… it might introduce confusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went through all the rules in plain-forge and fixed factual issues and added missing information.
Additionally, I've instructed Claude Code with the following prompt for each file in /rules:
Check all the facts in @forge/rules/X.md on real examples.Claude Code generated examples that tested the rules and come with many suggestions how to improve the rules in plain-forge and are now part of this pull request.
Here is the list of changes and fixes: