feat: implement issue detail view with claiming functionality (#276)#306
feat: implement issue detail view with claiming functionality (#276)#306PranavAgarkar07 wants to merge 5 commits into
Conversation
- Add getIssueDetail action with GitHub API fetch for body/comments - Add breadcrumb navigation (Issues / owner/repo / #number) - Add metadata header card with status, difficulty, XP, author - Add left action sidebar (New Branch, Settings, Docs, Status) - Add issue body rendering with markdown-like display - Add code context widget with diff viewer (current vs proposed) - Add discussion/comments section with avatars and level badges - Add claiming widget in right sidebar with 48h commitment - Add branch creation modal with auto-generated branch name - Use #0D0E12 pitch-black theme with glassmorphic panels
|
@PranavAgarkar07 is attempting to deploy a commit to the codersogs-3057's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I can't able to see the features you had mentioned in the description, also there's no page like the design given in the issue. It simply re-directs to the github upon click. Ping me if you have any doubts or questions. |
|
@Ayush-Patel-56 Good catch — the issue titles were still linking directly to GitHub. Fixed in 64e8e9d: clicking an issue title now navigates to /issues/[id] (the new detail page). The VIEW button still opens GitHub for the actual issue page. The page requires signing in via GitHub OAuth to render (auth gate in middleware), so the Vercel preview redirects to the landing page unless you're logged in. To test:
Can you give it another look once you're signed in? |
jakharmonika364
left a comment
There was a problem hiding this comment.
Solid structure overall - claim/unclaim flow and page layout follow the existing action/Result patterns well. Held up by two things that look finished but aren't: the code context diff and the branch-create button. Once those are either wired up or pulled, this is close.
| <div className="p-5"> | ||
| <div className="mb-3 flex items-center gap-2"> | ||
| <span className="rounded bg-zinc-800 px-2 py-1 font-mono text-[11px] text-zinc-400"> | ||
| src/lib/runner/cleanup.go |
There was a problem hiding this comment.
is this hardcoded for every issue? "cleanup.go" diff doesn't seem tied to the actual issue data
| Cancel | ||
| </button> | ||
| <button | ||
| onClick={confirmBranch} |
There was a problem hiding this comment.
confirmBranch just closes the modal, doesn't actually create anything, is branch creation wired up somewhere else?
| const handleUnclaim = async () => { | ||
| if (!issue.userRecId) return; | ||
| setClaimPending(true); | ||
| try { | ||
| await unclaimIssue(issue.userRecId); | ||
| setClaimResult('idle'); | ||
| router.refresh(); | ||
| } catch { | ||
| setClaimResult('error'); |
There was a problem hiding this comment.
not checking the result here, claimResult gets set to 'idle' even if unclaimIssue fails
| id: c.id, | ||
| avatarUrl: c.user?.avatar_url ?? null, | ||
| username: c.user?.login ?? 'unknown', | ||
| level: 1, |
There was a problem hiding this comment.
level hardcoded to 1, should this pull the commenter's real level?
| } | ||
| if (commentsRes.ok) { | ||
| const ghComments = await commentsRes.json(); | ||
| comments = ghComments.map((c: any) => ({ |
There was a problem hiding this comment.
any here, can probably type this from the GitHub comments response
| *.swo | ||
|
|
||
|
|
||
| screenshots/ |
There was a problem hiding this comment.
unrelated to this PR?
|
This PR has had no activity for 7 days. Are you still working on it? If so, please push an update or leave a comment. Otherwise it will be labeled |
Closes #276
Summary
Full Issue Detail page at
/issues/[id]with breadcrumbs, metadata, code context, discussion, and claim/unclaim workflow.Changes
Verification