fix: resolve forked repos to upstream correctly in issues filter (#315)#338
Open
Sujini-kudupudi wants to merge 2 commits into
Open
fix: resolve forked repos to upstream correctly in issues filter (#315)#338Sujini-kudupudi wants to merge 2 commits into
Sujini-kudupudi wants to merge 2 commits into
Conversation
Contributor
|
@Sujini-kudupudi is attempting to deploy a commit to the codersogs-3057's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Ayush-Patel-56
requested changes
Jun 18, 2026
Ayush-Patel-56
left a comment
Ayush-Patel-56
left a comment
Collaborator
There was a problem hiding this comment.
Logic looks solid and tests/lint passes. One thing before merge - getRepoOptions has no test covering the fork-resolution path itself (the exact thing #315 was about), just the empty-installs case. Can we add one mocking getInstallOctokit/repos.get for the fork-found + error-fallback cases? Don't want this regressing silently again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the ephemeral Supabase
provider_tokenwith the stable GitHub Appinstallation tokento authenticate GitHub API calls when detecting forked repositories in the Browse Issues filter. The previous token expired during live sessions causing the GitHub API checks to fail and return zero issues for forks.Type of Change
Related Issue
Closes #315
What was changed?
installation_repositoriesquery insrc/app/actions/issues.tsto includeinstallation_id.sb.auth.getSession()andprovider_tokenusage withgetInstallOctokit(installation_id)to authenticate API requests using the GitHub App token.octokit.repos.get({ owner, repo })for reliably checking if a repository is a fork and safely returning the upstreamparent.full_name.Screenshots
N/A
Checklist
npm run dev)