fix: add missing rate limiting to 5 server actions (#359)#367
Open
saurabhhhcodes wants to merge 1 commit into
Open
fix: add missing rate limiting to 5 server actions (#359)#367saurabhhhcodes wants to merge 1 commit into
saurabhhhcodes wants to merge 1 commit into
Conversation
getCommunityLinks, getCurrentStreak, getPublicStreak, getUsage,
and acknowledgeLevelUp were all missing rateLimit() calls while
neighboring functions in the same files had them.
- getCommunityLinks: 60 req/min (maint:community-links)
- getCurrentStreak: 60 req/min (streak:current)
- getPublicStreak: 120 req/min (streak:public, uses userId or anon key)
- getUsage: 60 req/min (usage:get)
- acknowledgeLevelUp: 30 req/min (level-ups:acknowledge, write op)
Non-Result functions return empty values when rate limited.
Result functions return err('rate_limited').
Contributor
|
Someone is attempting to deploy a commit to the codersogs-3057's projects Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
CI is failing, can you please fix it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #359
Summary
Five server actions were missing rateLimit() calls while neighboring functions in the same files had them. Added rate limiting to:
getCommunityLinksgetCurrentStreakgetPublicStreakgetUsageacknowledgeLevelUpType of Change
Checklist
npm run typecheck— passesnpm run lint— passes (only pre-existing warning in issues-list.tsx)npm run format:check— passes