fix: add smooth scroll, focus-visible styles, and skeleton animation#408
Open
saurabhhhcodes wants to merge 2 commits into
Open
fix: add smooth scroll, focus-visible styles, and skeleton animation#408saurabhhhcodes wants to merge 2 commits into
saurabhhhcodes wants to merge 2 commits into
Conversation
Contributor
|
Someone is attempting to deploy a commit to the codersogs-3057's projects Team on Vercel. A member of the Team first needs to authorize it. |
jakharmonika364
requested changes
Jun 24, 2026
jakharmonika364
left a comment
jakharmonika364
left a comment
Collaborator
There was a problem hiding this comment.
Two things before this can merge: drop the help-inbox hunk, it's a stale duplicate of #370 that's already superseded by #142's fix - probably what's causing the conflict. And the new html/*:focus-visible rules are unscoped, which breaks this file's own "scoped to .landing-root" rule in its header comment - they'll leak into the dashboard. Also missing a prefers-reduced-motion guard on the smooth scroll, and the skeleton colors are light-theme on a dark app and aren't used anywhere in this diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSS improvements:\n- Add smooth scroll behavior\n- Add visible focus-visible styles for keyboard accessibility\n- Add skeleton loading animation for async content