fix: atomic daily review XP cap check#411
Merged
jakharmonika364 merged 2 commits intoJun 24, 2026
Merged
Conversation
Contributor
|
@yush-1018 is attempting to deploy a commit to the codersogs-3057's projects Team on Vercel. A member of the Team first needs to authorize it. |
Ayush-Patel-56
requested changes
Jun 24, 2026
Comment on lines
+89
to
+94
| } catch (err: any) { | ||
| if (err.message === 'daily_review_cap_reached') { | ||
| throw err; | ||
| } | ||
| inserted = false; | ||
| } |
Collaborator
There was a problem hiding this comment.
this catch swallows any transaction error that isn't the cap message and just treats it as inserted = false - a real DB failure here would silently lose the reviewer's XP with no log or retry, since process-review-event's catch never gets a chance to see it. can you narrow this to only catch the duplicate/rollback case and rethrow everything else?
jakharmonika364
approved these changes
Jun 24, 2026
jakharmonika364
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #400 by enforcing the daily help review XP cap check atomically inside a database transaction rather than checking the count first in a separate non-atomic query.
Changes Made
Verification
pm run typecheck\ passes cleanly.
px vitest run src/lib/xp/events.test.ts\ passes with 13/13 tests green.
px vitest run src/inngest/functions/process-review-event.test.ts\ passes with 5/5 tests green.