refactor: extract evidence-matching helpers in maintainer.ts (fixes #416)#421
Open
Shiva210Jyoti wants to merge 1 commit into
Open
refactor: extract evidence-matching helpers in maintainer.ts (fixes #416)#421Shiva210Jyoti wants to merge 1 commit into
Shiva210Jyoti wants to merge 1 commit into
Conversation
Contributor
|
@Shiva210Jyoti is attempting to deploy a commit to the codersogs-3057's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
@jakharmonika364 The PR is ready for your review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #416
What
The
flag.evidence as any→ parse items →item.repo || item.repoFullName→ compare repos pattern was duplicated 3 times insrc/app/actions/maintainer.ts.Changes
Added 3 helpers just above
getFlaggedAccounts:repoFromEvidenceItem(item)— extractsrepoorrepoFullNameas a stringfilterEvidenceItemsByRepos(flag, repos)— returns matching evidence items (needed by the response builder to sumxpDelta)flagTouchesRepos(flag, repos)— boolean, delegates to the aboveCall sites updated
allowedFlagsfilter →return flagTouchesRepos(flag, repos);const filteredItems = filterEvidenceItemsByRepos(flag, repos);resolveFlaggedAccountauth check →const isAuthorized = flagTouchesRepos(flag, repos);Notes
Pure refactor - zero behavior change.
tsc,eslint, andvitestall pass.