Skip to content

Fix Mod Compatibility#120

Open
TheidenHD wants to merge 4 commits into
Coders-After-Dark:masterfrom
TheidenHD:master
Open

Fix Mod Compatibility#120
TheidenHD wants to merge 4 commits into
Coders-After-Dark:masterfrom
TheidenHD:master

Conversation

@TheidenHD

Copy link
Copy Markdown

Fix Mod Compatibility

Fix Mod Compatibility
@pupnewfster

Copy link
Copy Markdown
Contributor

I will look into this further/probably try to release an update with this when I get the chance just so that people can properly use the integrations with the newer versions of the mods. One thing to note is it may be a couple weeks though as I am finishing up my school semester and don't really feel like struggling to setup a 1.12 workspace until after I am done with classes.

Also there are two places that you missed updating the version number: https://github.com/Coders-After-Dark/CompatSkills/blob/master/src/main/resources/mcmod.info#L6 and https://github.com/Coders-After-Dark/CompatSkills/blob/master/src/main/java/codersafterdark/compatskills/utils/CompatSkillConstants.java#L8

It also would probably be ideal to update the min version of wizardry here to be whichever one they moved the class in as otherwise we would have the reverse issue that we break on older versions (the better questing change looks like it might be backwards compatible assuming the ordinal is fine, so probably doesn't need a version bump). If you aren't sure what to do here I can probably do it when I look into actually releasing this build later this month.

@fnar

fnar commented Jul 11, 2021

Copy link
Copy Markdown

Hey all, kind bump that there is eager excitement for this compatibility update if it is ready !

Thank you all for hard work and dedication to this thriving community. Your generosity and deep knowledge is the lifeblood that brings insurmountable fun, engagement, and genuine human connection to the members of the modded Minecraft community.

@reuy

reuy commented Jun 18, 2022

Copy link
Copy Markdown

I too, wish to see this merged.

@TheidenHD

TheidenHD commented Sep 12, 2022

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants