[BUGFIX] Translate column names in list module#50
Open
YKWeyer wants to merge 1 commit intoCodersCare:11-0from
Open
[BUGFIX] Translate column names in list module#50YKWeyer wants to merge 1 commit intoCodersCare:11-0from
YKWeyer wants to merge 1 commit intoCodersCare:11-0from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When viewing a grid in the page module, columns named with a valid translation string will display the corresponding translated value (done in the ColumnHeader template).
The same logic was missing in the list module, and the ll-labels were displayed instead.
This is now fixed by calling the LanguageService before outputting the column name in the list module for more consistency.
Fixes #51