Skip to content

🔧 config(coderabbit): adopt agent-voice tone and SYP best practices#127

Merged
scttbnsn merged 1 commit into
mainfrom
config/coderabbit-voice
Jul 5, 2026
Merged

🔧 config(coderabbit): adopt agent-voice tone and SYP best practices#127
scttbnsn merged 1 commit into
mainfrom
config/coderabbit-voice

Conversation

@scttbnsn

@scttbnsn scttbnsn commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Second pass pulling in the evolved config the SYP repos converged on:

  • tone_instructions: review comments written for an AI coding agent, terse, problem+fix, actionable only
  • high_level_summary_instructions: emoji changelog plus flat concern list, formatted for Claude Code to consume
  • Walkthrough noise stripped: collapsed walkthrough, no sequence diagrams, no effort estimate, no changed-files table, no fortune
  • auto_incremental_review on, drafts skipped, WIP/DO NOT MERGE titles skipped
  • Explicit tool enables for this stack (gitleaks, actionlint, markdownlint, yamllint, shellcheck, hadolint, ast-grep essential rules, github-checks) with languagetool off
  • pre_merge_checks: docstring/title/description gates off, linked-issue assessment as warning
  • Finishing touches (docstrings, unit tests) available on demand

✨ Added

  • Expanded .coderabbit.yaml with review prompting tuned for terse, actionable AI-agent feedback and a flat concern-oriented high-level summary.
  • Enabled early access/free-tier behavior and added incremental auto-review with draft/WIP/DO NOT MERGE title skipping.
  • Added finishing-touches and pre-merge check configuration, plus tool enablement for gitleaks, actionlint, markdownlint, yamllint, shellcheck, hadolint, essential ast-grep rules, and github-checks.
  • Added chat.art: false to the chat configuration.

🔧 Changed

  • Updated summary format instructions to an emoji changelog and concern list optimized for Claude Code consumption.
  • Relaxed several pre-merge gates around docstrings, titles, and descriptions.
  • Changed linked-issue assessment to warning-level.
  • Disabled languagetool in the tool stack.

🗑️ Removed

  • Walkthrough-heavy output patterns such as collapsed walkthroughs, sequence diagrams, effort estimates, changed-files tables, and fortune output.

@vercel

vercel Bot commented Jul 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sockguard-website Ready Ready Preview, Comment Jul 5, 2026 11:48pm

@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Config-only change: no Docker socket proxy code touched, no access-control paths widened. .coderabbit.yaml is replaced with an expanded configuration adding early_access/enable_free_tier, tone/summary prompt instructions, auto_review.ignore_title_keywords, new finishing_touches/pre_merge_checks/tools blocks (most pre-merge modes off, issue_assessment set to warning, several linters/security tools enabled with timeouts), and chat.art: false.

Changes

File Change
.coderabbit.yaml Expanded review/tone/prompt settings, added pre_merge_checks, tools, finishing_touches, chat.art

Related issues: None linked.

Related PRs: None found.

Suggested labels: review_needed_junior_swe, review_depth_standard

Suggested reviewers: none identified — no code owners of sockguard's socket-access logic touched here since this is config only.

No sequence diagram — config-only, no runtime code path.

Poem:
No sockets breached, no daemons stirred,
just YAML knobs politely blurred.
Timeouts set, tools switched on,
the proxy's guard remains — carry on.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch config/coderabbit-voice

Comment @coderabbitai help to get the list of available commands.

@biggest-littlest biggest-littlest left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config-only change, checked against the CodeRabbit v2 schema.

@ALARGECOMPANY ALARGECOMPANY left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config-only change, checked against the CodeRabbit v2 schema.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.coderabbit.yaml (1)

53-65: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Go repo, no vendor/generated-file exclusion. If vendor/ is committed, add it — noise in every review otherwise.

diff
     - "!**/*.lock"
+    - "!vendor/**"
+    - "!**/*.pb.go"
     - "!website/public/**"
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.coderabbit.yaml around lines 53 - 65, The path_filters in .coderabbit.yaml
are missing a vendor/ exclusion for this Go repository, which will cause review
noise if vendored code is committed. Update the path_filters list to also ignore
vendor/ alongside the existing generated/build artifact exclusions, keeping the
change in the same configuration block.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.coderabbit.yaml:
- Around line 53-65: The path_filters in .coderabbit.yaml are missing a vendor/
exclusion for this Go repository, which will cause review noise if vendored code
is committed. Update the path_filters list to also ignore vendor/ alongside the
existing generated/build artifact exclusions, keeping the change in the same
configuration block.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9833461a-31b9-4f0f-9343-af643e3fb350

📥 Commits

Reviewing files that changed from the base of the PR and between 0f63f16 and 2bdaaa1.

📒 Files selected for processing (1)
  • .coderabbit.yaml

@scttbnsn scttbnsn merged commit 4f7352d into main Jul 5, 2026
38 checks passed
@scttbnsn scttbnsn deleted the config/coderabbit-voice branch July 5, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants