[fix] Resolve CC computers attached to socket always being null - #134
Open
SamuelMereau wants to merge 1 commit into
Open
[fix] Resolve CC computers attached to socket always being null#134SamuelMereau wants to merge 1 commit into
SamuelMereau wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CommonCCCompatkeeps a record of every block entity that has a socket peripheral. Each time a new SocketPeripheral is constructed, this can overwrite an earlier existing block entity. Since each peripheral keeps track of their own attached computers, if it is overwritten, it loses this record and will not fire thereceive_signalevent to attached computers.This fix makes it so socket peripherals are only stored if no entry exists for the block entity, allowing the
receive_signalevent to be fired.Testing with 2 CC computers with the identical receiver script running:
Previously, both computers would have never received any signal event.
Demo after applying fix:
socket-fix-demo.mov