fix: jukeboxes not working on the radio - #144
Open
Plexi09 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug was that
CompatCore.getSound(...)treated any non-null value from platform/compatibility hooks as a valid sound identifier, so an empty string returned by a compat implementation (e.g. NeoForge) prevented falling back to the vanillaJukeboxSong.fromStack(...). BecauseMixinJukeboxSongPlayercallsRadioManager.sendRecord/updateRecordwith the jukeboxItemStack, that empty/invalid sound identifier got propagated into the radio pipeline and clients could not resolve or play the music disc. I fixed it by requiring the compat hook result to be non-null and non-blank (!result.isBlank()). This allows the code to fall back to the jukebox song data when the compat layer provides no valid sound.