Skip to content

Phase 0: Update Node to 20-alpine and Nginx to 1.27-alpine#10

Open
devin-ai-integration[bot] wants to merge 3 commits into
mainfrom
devin/1776939010-phase0-dockerfile-updates
Open

Phase 0: Update Node to 20-alpine and Nginx to 1.27-alpine#10
devin-ai-integration[bot] wants to merge 3 commits into
mainfrom
devin/1776939010-phase0-dockerfile-updates

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot commented Apr 23, 2026

Summary

Updates the Dockerfile base image versions as infrastructure prerequisites for the Angular migration:

  • Node: 16.3-alpine20-alpine
  • Nginx: 1.17.61.27-alpine

This is Phase 0 of a multi-phase Angular upgrade (16 → 17 → 18 → 19). Subsequent phases will update Angular and its dependencies.

Review & Testing Checklist for Human

  • Verify the Docker build succeeds end-to-end (docker build -t petclinic-test .). Node 16→20 is a major jump and npm install / npm run build may surface dependency incompatibilities even though the app code hasn't changed yet.
  • Verify the Nginx alpine image works with the existing sed commands on lines 23-24. The previous image (1.17.6) was Debian-based; 1.27-alpine is Alpine-based, so paths like /etc/nginx/conf.d/default.conf and /etc/nginx/nginx.conf should be confirmed to still exist.
  • Verify the HEALTHCHECK still functions. The current healthcheck uses [ "service", "nginx", "status" ], but Alpine images typically don't include the service command. This may need to change to wget --quiet --tries=1 --spider http://localhost:8080/ || exit 1 or similar — but that's a pre-existing issue that may now surface.
  • Run the built container and confirm the app is served correctly on port 8080.

Notes

  • The Nginx tag changed from a pinned version (1.17.6) to a floating minor tag (1.27-alpine). Consider pinning to a specific patch version (e.g., 1.27.4-alpine) for reproducible builds.
  • The old Nginx image was implicitly Debian-based; the new one is explicitly Alpine. This changes the runtime OS, which could affect debugging tools available inside the container.

Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/010af0d2621c4376ac0819869f987cf9


Open in Devin Review

@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants